Skip to content

Fix close position max size formatting#178

Open
nexicturbo wants to merge 1 commit into
capofficial:mainfrom
nexicturbo:codex/fix-close-size-formatting-max
Open

Fix close position max size formatting#178
nexicturbo wants to merge 1 commit into
capofficial:mainfrom
nexicturbo:codex/fix-close-size-formatting-max

Conversation

@nexicturbo
Copy link
Copy Markdown

@nexicturbo nexicturbo commented May 19, 2026

Summary

  • normalize the Close Position Max size before displaying it or inserting it into the Size to Close input
  • pass a real max bound into the shared numeric Input so close-size validation matches the formatted maximum
  • prevent submitting a close amount above the normalized max value

Fixes #11.

Validation

  • npm ci
  • npm run build
  • git diff --check

@nexicturbo nexicturbo mentioned this pull request May 19, 2026
Open
@nexicturbo
Copy link
Copy Markdown
Author

nexicturbo commented May 22, 2026

Quick validation refresh: I checked this branch against current upstream main; it is still only my focused commit ahead of upstream (git rev-list --left-right --count HEAD...origin/main -> 1 0), so no rebase was needed.

Fresh local validation:

  • npm run build (passes; only existing Svelte/Rollup warnings)
  • git diff --check

The visible red Vercel status points to account deployment being blocked (why-is-my-account-deployment-blocked), not a code/test failure on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Size to close is not well formatted, sometimes

1 participant

@nexicturbo